Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework toggle breakpoints for multiple selected lines #72685

Closed

Conversation

aXu-AP
Copy link
Contributor

@aXu-AP aXu-AP commented Feb 3, 2023

Partially fixes #72410
Fix bug if you toggle breakpoints when 2 carets are on the same line.
Changed behavior: A cool side effect, and maybe the more important feature is that you can now remove all breakpoints in selected lines. This is useful after you have done debugging a certain part of the code (but don't want to clear breakpoints from the whole file). For consistency this works in inverse too, you can add breakpoint for every line selected.
Breakpoint lines

Fix bug if 2 carets are on the same line.
Allow adding/removing all breakpoints on selected lines.
@aXu-AP aXu-AP requested a review from a team as a code owner February 3, 2023 20:08
@YuriSizov YuriSizov added this to the 4.0 milestone Feb 3, 2023
@aXu-AP
Copy link
Contributor Author

aXu-AP commented Feb 3, 2023

Work moved into #72671

@aXu-AP aXu-AP closed this Feb 3, 2023
@aXu-AP aXu-AP deleted the code-editor-toggle-breakpoints-fix branch February 15, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Various issues when multiple carets are on the same row
3 participants