Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework toggle breakpoints for multiple selected lines #72685

Closed
wants to merge 1 commit into from
Closed

Rework toggle breakpoints for multiple selected lines #72685

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 32 additions & 5 deletions editor/plugins/script_text_editor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1362,11 +1362,38 @@ void ScriptTextEditor::_edit_option(int p_op) {
code_editor->remove_all_bookmarks();
} break;
case DEBUG_TOGGLE_BREAKPOINT: {
for (int caret_idx = 0; caret_idx < tx->get_caret_count(); caret_idx++) {
int line = tx->get_caret_line(caret_idx);
bool dobreak = !tx->is_line_breakpointed(line);
tx->set_line_as_breakpoint(line, dobreak);
EditorDebuggerNode::get_singleton()->set_breakpoint(script->get_path(), line + 1, dobreak);
Vector<int> lines;
Vector<int> caret_edit_order = tx->get_caret_index_edit_order();
for (int p_caret : caret_edit_order) {
int from, to;
if (tx->has_selection(p_caret)) {
from = tx->get_selection_from_line(p_caret);
to = tx->get_selection_to_line(p_caret);
// Don't affect a line with no selected characters
if (tx->get_selection_to_column(p_caret) == 0) {
to--;
}
} else {
from = tx->get_caret_line(p_caret);
to = from;
}
for (int line = to; line >= from; line--) {
if (!lines.has(line)) {
lines.append(line);
}
}
}

bool selection_has_breakpoints = false;
for (const int &line : lines) {
if (tx->is_line_breakpointed(line)) {
selection_has_breakpoints = true;
break;
}
}
for (const int &line : lines) {
tx->set_line_as_breakpoint(line, !selection_has_breakpoints);
EditorDebuggerNode::get_singleton()->set_breakpoint(script->get_path(), line + 1, !selection_has_breakpoints);
}
} break;
case DEBUG_REMOVE_ALL_BREAKPOINTS: {
Expand Down