Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Unit tests for viewport.cpp Physics 2D Picking #73477

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Add Unit tests for viewport.cpp Physics 2D Picking #73477

merged 1 commit into from
Aug 7, 2023

Conversation

Sauermann
Copy link
Contributor

@Sauermann Sauermann commented Feb 17, 2023 •
edited
Loading

part of #43440

Improve coverage of viewport.cpp:

image image

Updated 2023-08-06: resolve merge conflict

@Sauermann Sauermann requested a review from a team as a code owner February 17, 2023 02:28
@Sauermann Sauermann force-pushed the fix-viewport-picking-unittest branch from 31c6edb to 3d2c39e Compare February 17, 2023 02:37
@akien-mga akien-mga modified the milestones: 4.0, 4.x Feb 17, 2023
@Sauermann Sauermann force-pushed the fix-viewport-picking-unittest branch from 3d2c39e to 3e71144 Compare June 10, 2023 07:19
@Sauermann
Copy link
Contributor Author

I have updated the unit-tests to include changes from #78017.

@Sauermann Sauermann modified the milestones: 4.x, 4.2 Jul 14, 2023
@Sauermann Sauermann force-pushed the fix-viewport-picking-unittest branch from 3e71144 to a6a8901 Compare July 26, 2023 20:14
@Sauermann Sauermann force-pushed the fix-viewport-picking-unittest branch from a6a8901 to 9e7d4c8 Compare August 6, 2023 15:55
@Calinou
Copy link
Member

Calinou commented Aug 7, 2023 •
edited
Loading

Improve coverage of viewport.cpp:

Out of curiosity, what tool did you use to generate the coverage table?

Calinou
Calinou reviewed Aug 7, 2023
View reviewed changes
tests/scene/test_viewport.h Outdated Show resolved Hide resolved
Calinou
Calinou approved these changes Aug 7, 2023
View reviewed changes
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good to merge after fixing the typo.

@Sauermann Sauermann force-pushed the fix-viewport-picking-unittest branch from 9e7d4c8 to 9014e9e Compare August 7, 2023 07:06
@Sauermann
Copy link
Contributor Author

Typo is fixed. Thanks for that.

Out of curiosity, what tool did you use to generate the coverage table?

Please see #43440 (comment)

@akien-mga akien-mga merged commit 40f116f into godotengine:master Aug 7, 2023
@Sauermann Sauermann deleted the fix-viewport-picking-unittest branch August 7, 2023 13:03
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Calinou Calinou Calinou approved these changes

Assignees
No one assigned
Labels
enhancement topic:input topic:physics topic:tests
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
3 participants
@Sauermann @Calinou @akien-mga