Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.x] Enable granular control of touchscreen related settings #73692

Merged
merged 2 commits into from
May 8, 2023
Merged

[3.x] Enable granular control of touchscreen related settings #73692

merged 2 commits into from
May 8, 2023

Conversation

m4gr3d
Copy link
Contributor

@m4gr3d m4gr3d commented Feb 21, 2023 •
edited
Loading

Adds a Touchscreen section in the editor settings to host touchscreen related settings.

This PR includes:

  • First commit: Adds the ability to disable long press as right click, and disable pan and scale gestures on touchscreen devices.
  • Second commit:
    • Adds a scale_editor_icons entry to the Touchscreen editor settings. When enabled, this scales the editor icons to improve usability on touchscreen devices.
    • Fixes touch detection for the collision_shape_2d_editor_plugin so it scales with the icons size.

Fixes #72725
Fixes the Resize a CollisionShape2D and the Move Path2D Nodes issues in #73707

  • Non touchscreen ui
    Screenshot_20230405_150537_Godot Editor 3 (dev)

  • Touchscreen ui
    Screenshot_20230405_150513_Godot Editor 3 (dev)

main version

@m4gr3d m4gr3d added this to the 3.6 milestone Feb 21, 2023
@m4gr3d m4gr3d requested review from a team as code owners February 21, 2023 17:26
@m4gr3d m4gr3d changed the title Enable granular control of touchscreen related settings [3.x] Enable granular control of touchscreen related settings Feb 21, 2023
@m4gr3d m4gr3d force-pushed the update_touchscreen_editor_settings_3x branch from 229ba8f to ea20176 Compare February 21, 2023 17:39
@m4gr3d m4gr3d mentioned this pull request Feb 21, 2023
Merged
@m4gr3d m4gr3d force-pushed the update_touchscreen_editor_settings_3x branch from ea20176 to 818646f Compare February 22, 2023 08:20
@m4gr3d m4gr3d force-pushed the update_touchscreen_editor_settings_3x branch from 818646f to 61e41fa Compare April 5, 2023 17:12
@m4gr3d m4gr3d requested a review from a team as a code owner April 5, 2023 19:30
@m4gr3d m4gr3d mentioned this pull request Apr 5, 2023
Merged
@m4gr3d m4gr3d force-pushed the update_touchscreen_editor_settings_3x branch from 445f5ea to ab57dc5 Compare April 5, 2023 21:55
@m4gr3d m4gr3d requested a review from KoBeWi April 13, 2023 16:37
@m4gr3d m4gr3d requested a review from groud April 24, 2023 01:31
@m4gr3d m4gr3d force-pushed the update_touchscreen_editor_settings_3x branch 3 times, most recently from a44a77f to 5ea96c6 Compare May 6, 2023 14:27
@m4gr3d
Adds a scale_gizmo_handles entry to the Touchscreen editor settings
b78935e 
When enabled, this scales the editor icons to improve usability on touchscreen devices.
In addition this commit fixes touch detection for the collision_shape_2d_editor_plugin so it scales with the icons size.
@m4gr3d m4gr3d force-pushed the update_touchscreen_editor_settings_3x branch from 5ea96c6 to b78935e Compare May 7, 2023 22:57
KoBeWi
KoBeWi approved these changes May 8, 2023
View reviewed changes
Copy link
Member

@KoBeWi KoBeWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test it, but the code looks pretty much the same as on master, so it's likely ok.

@m4gr3d m4gr3d merged commit f9ae38d into godotengine:3.x May 8, 2023
@m4gr3d m4gr3d deleted the update_touchscreen_editor_settings_3x branch May 8, 2023 16:10
@lawnjelly lawnjelly mentioned this pull request May 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KoBeWi KoBeWi KoBeWi approved these changes

@groud groud Awaiting requested review from groud

Assignees
No one assigned
Labels
bug platform:android topic:editor topic:porting
Projects
None yet
Milestone
3.6
Development

Successfully merging this pull request may close these issues.
2 participants
@m4gr3d @KoBeWi