-
-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unnecessary break when calculating the height of visible lines #77280
Fix unnecessary break when calculating the height of visible lines #77280
Conversation
This break causes the minsize to be smaller than expected, and then the size keeps increasing by one line to cover all visible lines. This can cause performance issues when there are many visible lines.
This comment was marked as resolved.
This comment was marked as resolved.
Tested locally (rebased against With a debug editor build (
|
CC @bruvzg |
Thanks! |
Note for @YuriSizov: If we want to cherry-pick this for 4.1.x (which may be good given that it fixes a significant performance issue), we need to handle #80218 there too. Your diff in #80218 (comment) might be suitable? |
@akien-mga Unfortunately that diff can only be used as a reference. In 4.1 we would need to give min sizes to labels in each validation form individually. The principle would be the same, just a bit more laborious. |
Given that we can trace various sizing issues to this PR, I wouldn't go for cherry-picking it into 4.1. If we were to do this, we would need to port all follow-up fixes as well, which seems more effort than it's worth at this point. |
This break causes the minsize to be smaller than expected, and then the size keeps increasing by one line to cover all visible lines. This can cause performance issues when there are many visible lines.
Fix #77268.