-
-
Notifications
You must be signed in to change notification settings - Fork 21.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set an appropriate minimum size for labels in windows that display incorrectly #86145
Merged
akien-mga
merged 1 commit into
godotengine:master
from
Rindbee:set-a-suitable-size-for-labels-with-AUTOWRAP_WORD_SMART
Jan 15, 2024
Merged
Set an appropriate minimum size for labels in windows that display incorrectly #86145
akien-mga
merged 1 commit into
godotengine:master
from
Rindbee:set-a-suitable-size-for-labels-with-AUTOWRAP_WORD_SMART
Jan 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
added
bug
topic:editor
regression
topic:export
cherrypick:4.2
Considered for cherry-picking into a future 4.2.x release
labels
Dec 14, 2023
YuriSizov
previously approved these changes
Jan 12, 2024
YuriSizov
reviewed
Jan 12, 2024
YuriSizov
reviewed
Jan 12, 2024
YuriSizov
suggested changes
Jan 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above.
Rindbee
force-pushed
the
set-a-suitable-size-for-labels-with-AUTOWRAP_WORD_SMART
branch
from
January 12, 2024 14:43
e9bf368
to
b778f65
Compare
Rindbee
changed the title
Set an appropriate size for labels in windows that display incorrectly
Set an appropriate minimum size for labels in windows that display incorrectly
Jan 12, 2024
YuriSizov
approved these changes
Jan 12, 2024
…correctly When the label's `autowrap_mode` is `AUTOWRAP_WORD_SMART` and the initial `text` is set at the same time, it may have a higher height. Set an appropriate minimum size for labels in windows that display incorrectly so that these controls display properly.
Rindbee
force-pushed
the
set-a-suitable-size-for-labels-with-AUTOWRAP_WORD_SMART
branch
from
January 12, 2024 15:08
b778f65
to
f932c65
Compare
AThousandShips
approved these changes
Jan 12, 2024
Thanks! |
Rindbee
deleted the
set-a-suitable-size-for-labels-with-AUTOWRAP_WORD_SMART
branch
January 15, 2024 12:41
YuriSizov
removed
the
cherrypick:4.2
Considered for cherry-picking into a future 4.2.x release
label
Jan 25, 2024
Cherry-picked for 4.2.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the label's
autowrap_mode
isAUTOWRAP_WORD_SMART
and the initialtext
is set at the same time, it may have a higher height than expected. See #80218 (comment) for more details.Set an appropriate minimum size for labels in windows that display incorrectly so that these windows display properly.
As a workaround for display issues in the editor caused by #77280.
Close #86136.
Closes #85551.