Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix export window size getting epic proportions #87021

Closed
wants to merge 1 commit into from

Conversation

hakro
Copy link
Contributor

@hakro hakro commented Jan 9, 2024

Fixes #85551

Not sure why, but the smart autowrap on the seemingly harmless label server_strip_message gives the export window a crazy height whenExport Mode is set to Export as dedicated server , making it impossible to access the buttons to export your project when in Single Window Mode.
That label is only supposed to hold some information text, listing the resources that will be stripped from the server export.

For some reason changing the autowrap mode to something else fixes the issue. So I switched it to AUTOWRAP_WORD here, which should look quite similar to what's intended.

Might be a TextServer issue, but I have not looked into that.

@AThousandShips AThousandShips added this to the 4.3 milestone Jan 9, 2024
@dsnopek dsnopek self-requested a review January 9, 2024 23:39
Copy link
Contributor

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for digging into this!

I tested this PR and it fixed the issue for me. And, as the original author of the line you changing (sorry!), I can say that we don't need it to be AUTOWRAP_WORD_SMART for any particular reason - using AUTOWRAP_WORD should be fine.

@Calinou
Copy link
Member

Calinou commented Jan 10, 2024

Fixes #86136

It turns out I've opened a duplicate of that issue: #86136

There is another fix here: #86145

@MewPurPur
Copy link
Contributor

MewPurPur commented Jan 10, 2024

I'm interested in what's causing WORD_SMART to cause this travesty. I wouldn't like it causing any nasty bugs in my projects.

@akien-mga akien-mga requested a review from YuriSizov January 11, 2024 16:30
@YuriSizov
Copy link
Contributor

Thanks for opening a PR! The one linked by Calinou, #86145, is the correct way to address this for now.

Changing to another autowrapping behavior is not going to fix the issue, ultimately. The problem is with the autowrapping itself, not with this specific mode. Problem with autowrapping is that without any sensible default size the control will try to shrink to its minimum allowed size. Autowrapping makes it possible for the control to shrink to the size of its smallest text unit horizontally, because it can wrap around the remainder. This causes it to initially compute itself to have its smallest width, but as a result it has its biggest height.

A different wrapping mode is just changing the size of that smallest width, but not the rest of the behavior. Of course if your smallest unit is a word instead of a character, the vertical expansion won't be as dramatic. But the underlying problem will still be present. So for now we must give labels with wrapping a reasonable width, like #86145 does.

So I'm going to close this PR, but thanks nevertheless!

@YuriSizov YuriSizov closed this Jan 12, 2024
@YuriSizov YuriSizov removed this from the 4.3 milestone Jan 12, 2024
@hakro hakro deleted the fix-export-window-size branch January 12, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[4.2] Export Window Sized outside of screen, cannot be resized when export template is selected
6 participants