Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make editor inspector follow focus #78960

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Make editor inspector follow focus #78960

merged 1 commit into from
Jan 4, 2024

Conversation

kleonc
Copy link
Member

@kleonc kleonc commented Jul 2, 2023

No idea if this could have any negative implications. 🤔

Fixes #78954 (EditorSettingsDialog uses SectionedInspector which uses EditorInspector).
OyeUr5dpyO

@kleonc kleonc added this to the 4.2 milestone Jul 2, 2023
@kleonc kleonc force-pushed the inspector-follow-focus branch from 0ce1884 to c6e8950 Compare July 2, 2023 20:36
@kleonc kleonc requested a review from a team as a code owner July 2, 2023 20:36
@YuriSizov YuriSizov added enhancement and removed bug labels Oct 30, 2023
@YuriSizov YuriSizov modified the milestones: 4.2, 4.3 Oct 30, 2023
YuriSizov
YuriSizov approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@YuriSizov YuriSizov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably good, but let's wait for 4.3 dev cycle.

@akien-mga akien-mga merged commit c772a5b into godotengine:master Jan 4, 2024
@akien-mga
Copy link
Member

Thanks!

@kleonc kleonc deleted the inspector-follow-focus branch January 4, 2024 20:44
@matheusmdx matheusmdx mentioned this pull request May 2, 2024
Closed
@matheusmdx matheusmdx mentioned this pull request Sep 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuriSizov YuriSizov YuriSizov approved these changes

Assignees
No one assigned
Labels
enhancement topic:editor topic:gui usability
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Tab cycling doesn't scroll the focused Editor setting into view
3 participants
@kleonc @akien-mga @YuriSizov