Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing arrows in integer vector properties #79021

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Fix missing arrows in integer vector properties #79021

merged 1 commit into from
Nov 9, 2023

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Jul 4, 2023

Fixes regression from #77135
Apparently hide_slider will also hide arrows. I clarified the documentation.

Before
image

After
image

(Seems like Vector4/i might need the same treatment as Rect2.)

@KoBeWi KoBeWi added bug topic:editor usability regression cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Jul 4, 2023
@KoBeWi KoBeWi added this to the 4.2 milestone Jul 4, 2023
@KoBeWi KoBeWi requested a review from a team as a code owner July 4, 2023 13:22
@KoBeWi KoBeWi mentioned this pull request Jul 4, 2023
Open
@KoBeWi KoBeWi mentioned this pull request Aug 22, 2023
Open
YuriSizov
YuriSizov approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@YuriSizov YuriSizov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine, but could you rebase against master so it passes all the up-to-date CI checks?

@KoBeWi KoBeWi force-pushed the hide_slider_and_EVERYTHING_ELSE branch from 9fb01ca to aff49d3 Compare November 9, 2023 16:35
@akien-mga akien-mga merged commit 460dd9f into godotengine:master Nov 9, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@KoBeWi KoBeWi deleted the hide_slider_and_EVERYTHING_ELSE branch November 9, 2023 17:25
@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Jan 23, 2024
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.4.

@mhilbrunner mhilbrunner mentioned this pull request May 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuriSizov YuriSizov YuriSizov approved these changes

Assignees
No one assigned
Labels
bug regression topic:editor usability
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
3 participants
@KoBeWi @akien-mga @YuriSizov