Make Vector4/i properties show in 2x2 layout #80893
Conversation
| @@ -3708,14 +3708,14 @@ EditorProperty *EditorInspectorDefaultPlugin::get_editor_for_property(Object *p_ | |||
|
|
|||
| } break; | |||
| case Variant::VECTOR4: { | |||
| EditorPropertyVector4 *editor = memnew(EditorPropertyVector4); | |||
| EditorPropertyVector4 *editor = memnew(EditorPropertyVector4(p_wide)); | |||
There was a problem hiding this comment.
Unrelated change. I just noticed it's missing.
|
What about Plane? I think the other one went through more easily because xy and hw are separate concepts, but here xyzw are just positions in identical dimensions |
Looks like another duplicate property 🙄
The original PR was about having more space, I never considered the concepts. Vector4 didn't exist then and I don't use Plane, so I didn't know it also has this problem (though Rect2 is probably used more in general). |
|
A vector4 doesn't naturally have a 2x2 structure like a transform 2d has. Can you explain this change? |
|
See godotengine/godot-proposals#2237 |
|
I'm not totally sure about this. Especially when I work with shaders a lot with many vec3, vec4 and mat4 types I feel this can make the UI a bit more confusing. Keeping all vector values in one row (except for weirdo Vector2) makes eyeballing the UI easy and there is a visual difference between vectors and matrices. Making Vector4 take two rows makes it easy to mistake for a matrix. And if Vector4 takes too much space horizontally, what should mat4 or Projection look like? It also takes four slots horizontally right now and it's hard to image how the new layout would look like without breaking the currently 1-to-1 visual to data mapping.
|
|
I think this should be tied to another editor setting like interface/inspector/horizontal_vector2_editing and interface/inspector/horizontal_vector_types_editing, although it's really pushing it. The latter is also a "lie" if this PR displays it this way regardless of the setting. |
|
I think it would be confusing to add 2x2 layout for Vector4, but I'm not strongly attached to that position. |
Vector4 version of #45713
Before:
After:
With link:
This is going to be especially relevant for Vector4i properties after #79021
It also allows to unify Rect and Vector editor properties.