-
-
Notifications
You must be signed in to change notification settings - Fork 21.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename button_pressed
default signal binding to avoid shadowing
#79064
Rename button_pressed
default signal binding to avoid shadowing
#79064
Conversation
4d76dc6
to
05bf32b
Compare
But commit seems confused :P |
Documentation for signal hasn't been corrected |
Oh, my terminal often glitches out on newlines and screws up text... Do I gotta amend it? And I think I did fix up docs, is there something other than BaseButton.xml I have to fix? |
You have to fix the documentation for the signal, the argument name, you've only updated the virtual function |
Yes, with |
05bf32b
to
3d128f6
Compare
pokepoke? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Technically breaks compat for C# if users were using named arguments... but that's not the first nor the last.
button_pressed
default signal binding to avoid shadowing
Thanks! |
Title says it all :3