Clear the previously set state when configuring for a new scene root node #79201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The fix is much appreciated, but these changes only sporadically resolve #79176 for me - sometimes the scene with the Subviewport and ViewportTexture will open correctly, but other times they will not. |
Rindbee
force-pushed
the
fix-setup-state-not-cleared
branch
from
c3efb35 to
ec39551
Compare
|
Comparing addresses seems to be unreliable. Because the node pointed to by |
|
This version does appear to fix #79176, thanks! |
akien-mga
added
topic:core
cherrypick:4.1
|
I think the method name should be more descriptive, like |
…node Saving a subscene causes the main scene to be re-instantiated. And the resource instance in the main scene will be reused when the main scene is re-instantiated. So for resources with `resource_local_to_scene` enabled, resetting state may be necessary (at least for `ViewportTexture`).
Rindbee
force-pushed
the
fix-setup-state-not-cleared
branch
from
ec39551 to
4795c3c
Compare
KoBeWi
approved these changes
Aug 8, 2023
|
Thanks! |
|
Cherry-picked for 4.1.3. |
YuriSizov
removed
the
cherrypick:4.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saving a subscene (or other reasons) causes the main scene to be re-instantiated. And the resource instance in the main scene will be reused when the main scene is re-instantiated. So for resources with
resource_local_to_sceneenabled, resetting state may be necessary (at least forViewportTexture).Fix #69469, fix #79176, fix #77981, fix #74080, fix #80417.