-
-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overhaul bool documentation #80141
Merged
Merged
Overhaul bool documentation #80141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalexeev
reviewed
Aug 2, 2023
aaronfranke
reviewed
Aug 2, 2023
Mickeon
force-pushed
the
doc-peeves-boolwing
branch
from
August 2, 2023 07:27
3e45856
to
f6d056d
Compare
Pushed a commit to apply both aforementioned suggestions. |
MewPurPur
reviewed
Aug 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only this
Mickeon
force-pushed
the
doc-peeves-boolwing
branch
from
August 2, 2023 07:54
f6d056d
to
69146f6
Compare
Yeah. |
aaronfranke
approved these changes
Aug 2, 2023
akien-mga
approved these changes
Aug 3, 2023
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of similar past efforts that aim for the same goal of refreshing the documentation up a notch.
Albeit the page is small, I did spend the whole day shaking off the rust.
can_shoot
;is_reloading
a method. Its name matches Godot's method naming scheme more than properties.bool(int)
andbool(float)
constructors.!=
for booleans is essentially the logical XOR;Feedback is very, very welcome.