Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C#: Improve diagnostic messages and add help link #80489

Merged
merged 1 commit into from
Oct 17, 2023
Merged

C#: Improve diagnostic messages and add help link #80489

merged 1 commit into from
Oct 17, 2023

Conversation

raulsntos
Copy link
Member

@raulsntos raulsntos added this to the 4.x milestone Aug 10, 2023
This was referenced Aug 10, 2023
Merged
Merged
@mhilbrunner
Copy link
Member

We merged the docs counterpart PR.

@raulsntos raulsntos marked this pull request as ready for review August 26, 2023 11:35
@raulsntos raulsntos requested a review from a team as a code owner August 26, 2023 11:35
@raulsntos raulsntos mentioned this pull request Sep 20, 2023
Open
YuriSizov
YuriSizov approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@YuriSizov YuriSizov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that you should de-hardcode the link base, but LGTM otherwise.

@YuriSizov YuriSizov modified the milestones: 4.x, 4.2 Oct 17, 2023
@raulsntos raulsntos force-pushed the dotnet/diagnostics branch 2 times, most recently from 404ef4e to bfea713 Compare October 17, 2023 17:25
@raulsntos
C#: Improve diagnostic messages and add help link
aa4dba5 
- Reword diagnostic messages.
- Add help link to diagnostics.
@akien-mga akien-mga merged commit ca09afd into godotengine:master Oct 17, 2023
@akien-mga
Copy link
Member

Thanks!

@raulsntos raulsntos deleted the dotnet/diagnostics branch October 17, 2023 23:46
@raulsntos raulsntos mentioned this pull request Oct 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuriSizov YuriSizov YuriSizov approved these changes

Assignees
No one assigned
Labels
enhancement topic:dotnet
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
4 participants
@raulsntos @mhilbrunner @akien-mga @YuriSizov