Rework update_property for array

[ajreckof]

Fixes #75124

This is a huge rework of how array property editor is updated. Previously it would delete every editor for each element and recreate them. Now it first check whether the property editor will be the same.

This is not 100% tested but I couldn't find other bugs so decided to share to see if other people could find some bugs while I'm finishing testing otr if they had any suggestion on the code

[AThousandShips]

You also need to rebase, your branch is far far behind, about a month and a half

[ajreckof]

Just realised I forgot to tell. This fix only the array part of the issue linked and not the dictionary part I will deal with dictionnaries with my rework of the dictionary editor.

[Calinou]

Tested locally (rebased on top of master 6758a7f), it works as expected (including on multi-page arrays).

Note that an issue that causes the entire array's contents to disappear (including in the saved data) still occurs if you happen to right-click the area on the left between the drag-and-drop icon and the property name then choose Paste Value.

[ajreckof]

Note that an issue that causes the entire array's contents to disappear (including in the saved data) still occurs if you happen to right-click the area on the left between the drag-and-drop icon and the property name then choose Paste Value.

Was that happening before my PR or was it something introduced with this?
If it is not related I might know what is happening. I'll try to make a PR to fix it but if it is what I'm thinking then it will be a separated PR from this one as they are in fact not linked.

[Calinou]

Was that happening before my PR or was it something introduced with this?

It's not introduced by the PR, I can reproduce it in master too: #80974

It's a separate issue and can be fixed in a separate PR.

[KoBeWi]

Dragging array elements may make the cursor disappear permanently.

Changing array type in code (in this case from Resource to Node) results in this error

 Attempted to set an object of type 'Node' into a TypedArray, which does not inherit from 'Resource'.
  C:\godot_source\core/variant/array.cpp:413 - Condition "!_p->typed.validate(value, "set")" is true.

You can't assign anything until reloading the scene.

[ajreckof]

Changing array type in code (in this case from Resource to Node) results in this error

 Attempted to set an object of type 'Node' into a TypedArray, which does not inherit from 'Resource'.
  C:\godot_source\core/variant/array.cpp:413 - Condition "!_p->typed.validate(value, "set")" is true.

This is something already present in master. When testing my own PR I stumbled upon it too. The problem on the back end that it can still hold an array that is not of the right type. Normally returning to default is enough to fix it which is a bit less tenuous then re opening the scene.

[ajreckof]

Dragging array elements may make the cursor disappear permanently.

I'm not sure about this one but it seems like it was present before my PR. But I'm not sure I'm looking at the same that causes the mouse to fully disappear. Mine is to focus ones of the button to drag element and then long press enter.

[KoBeWi]

It's worse after the last update xd

@export var array: Array[int]

Change array size to 21, you'll get spammed with

ERROR: Condition "p_elem->_root != this" is true.
   at: SelfList<class Node>::List::remove (C:\godot_source\core/templates/self_list.h:80)

and the editor crashes when you unselect the node:

CrashHandlerException: Program crashed
Engine version: Godot Engine v4.2.dev.custom_build (545d1c0adbf340310e1531710eb31bd5267704d5)
Dumping the backtrace. Please include this when reporting the bug to the project developer.
[0] Viewport::_gui_remove_control (C:\godot_source\scene\main\viewport.cpp:2423)
[1] Control::_notification (C:\godot_source\scene\gui\control.cpp:3173)
[2] Control::_notificationv (C:\godot_source\scene\gui\control.h:48)
[3] TextureRect::_notificationv (C:\godot_source\scene\gui\texture_rect.h:37)
[4] Object::notification (C:\godot_source\core\object\object.cpp:844)
[5] Node::_propagate_exit_tree (C:\godot_source\scene\main\node.cpp:341)
[6] Node::_propagate_exit_tree (C:\godot_source\scene\main\node.cpp:332)
[7] Node::_propagate_exit_tree (C:\godot_source\scene\main\node.cpp:332)
[8] Node::_propagate_exit_tree (C:\godot_source\scene\main\node.cpp:332)
[9] Node::_propagate_exit_tree (C:\godot_source\scene\main\node.cpp:332)
[10] Node::_propagate_exit_tree (C:\godot_source\scene\main\node.cpp:332)
[11] Node::_propagate_exit_tree (C:\godot_source\scene\main\node.cpp:332)
[12] Node::_propagate_exit_tree (C:\godot_source\scene\main\node.cpp:332)
[13] Node::_propagate_exit_tree (C:\godot_source\scene\main\node.cpp:332)
[14] Node::_set_tree (C:\godot_source\scene\main\node.cpp:2920)
[15] Node::remove_child (C:\godot_source\scene\main\node.cpp:1453)
[16] Node::_notification (C:\godot_source\scene\main\node.cpp:210)
[17] Node::_notificationv (C:\godot_source\scene\main\node.h:49)
[18] CanvasItem::_notificationv (C:\godot_source\scene\main\canvas_item.h:45)
[19] Control::_notificationv (C:\godot_source\scene\gui\control.h:48)
[20] Container::_notificationv (C:\godot_source\scene\gui\container.h:37)
[21] BoxContainer::_notificationv (C:\godot_source\scene\gui\box_container.h:37)
[22] VBoxContainer::_notificationv (C:\godot_source\scene\gui\box_container.h:90)
[23] Object::notification (C:\godot_source\core\object\object.cpp:844)
[24] Object::_predelete (C:\godot_source\core\object\object.cpp:199)
[25] predelete_handler (C:\godot_source\core\object\object.cpp:2028)
[26] memdelete<Node> (C:\godot_source\core\os\memory.h:105)
[27] EditorInspector::_clear (C:\godot_source\editor\editor_inspector.cpp:3457)
[28] EditorInspector::edit (C:\godot_source\editor\editor_inspector.cpp:3482)
[29] EditorNode::push_item (C:\godot_source\editor\editor_node.cpp:2179)
[30] EditorNode::push_node_item (C:\godot_source\editor\editor_node.cpp:2172)
[31] SceneTreeDock::_push_item (C:\godot_source\editor\scene_tree_dock.cpp:1492)
[32] SceneTreeDock::_selection_changed (C:\godot_source\editor\scene_tree_dock.cpp:2294)
[33] call_with_variant_args_helper<SceneTreeDock> (C:\godot_source\core\variant\binder_common.h:308)
[34] call_with_variant_args<SceneTreeDock> (C:\godot_source\core\variant\binder_common.h:418)
[35] CallableCustomMethodPointer<SceneTreeDock>::call (C:\godot_source\core\object\callable_method_pointer.h:105)
[36] Callable::callp (C:\godot_source\core\variant\callable.cpp:51)
[37] Object::emit_signalp (C:\godot_source\core\object\object.cpp:1118)
[38] Object::emit_signal<> (C:\godot_source\core\object\object.h:920)
[39] EditorSelection::_emit_change (C:\godot_source\editor\editor_data.cpp:1299)
[40] call_with_variant_args_helper<EditorSelection> (C:\godot_source\core\variant\binder_common.h:308)
[41] call_with_variant_args_dv<EditorSelection> (C:\godot_source\core\variant\binder_common.h:451)
[42] MethodBindT<EditorSelection>::call (C:\godot_source\core\object\method_bind.h:337)
[43] Object::callp (C:\godot_source\core\object\object.cpp:767)
[44] Callable::callp (C:\godot_source\core\variant\callable.cpp:62)
[45] CallQueue::_call_function (C:\godot_source\core\object\message_queue.cpp:220)
[46] CallQueue::flush (C:\godot_source\core\object\message_queue.cpp:326)
[47] SceneTree::physics_process (C:\godot_source\scene\main\scene_tree.cpp:473)
[48] Main::iteration (C:\godot_source\main\main.cpp:3535)
[49] OS_Windows::run (C:\godot_source\platform\windows\os_windows.cpp:1474)
[50] widechar_main (C:\godot_source\platform\windows\godot_windows.cpp:182)
[51] _main (C:\godot_source\platform\windows\godot_windows.cpp:204)
[52] main (C:\godot_source\platform\windows\godot_windows.cpp:218)
[53] WinMain (C:\godot_source\platform\windows\godot_windows.cpp:232)
[54] __scrt_common_main_seh (D:\a\_work\1\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288)
[55] <couldn't map PC to fn name>
-- END OF BACKTRACE --

[ajreckof]

I reversed the memfree changes and I can't reproduce. I'm not sure how this caused this bug so I don't know how to fix except keeping queue_free

[KoBeWi]

I did more testing to the disappearing mouse bug (using Windows) and it seems to be introduced by this PR.
Without this PR:

YxigaWlelf.mp4

I can drag as much as I want and nothing happens.
With this PR:

U6y499hKJJ.mp4

It breaks after a few drags, consistently.

[ajreckof]

I finally took the time to look at what was happenning with what kobewi reported. It was simply that in some condition I was deleting the slot that was being dragged around. I also added AThousandShips improvement.

[akien-mga]

Thanks!