Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix redundant enter tree notification in project export texture format #80967

Merged
merged 1 commit into from
Aug 25, 2023
Merged

Fix redundant enter tree notification in project export texture format #80967

merged 1 commit into from
Aug 25, 2023

Conversation

aaronfranke
Copy link
Member

Fixes #78457 (comment)

As Yuri correctly noted, NOTIFICATION_THEME_CHANGED happens when "The node enters the scene tree".

@aaronfranke aaronfranke added this to the 4.2 milestone Aug 24, 2023
YuriSizov
YuriSizov approved these changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@YuriSizov YuriSizov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't really urgent to fix, we probably still have a few of those in the codebase, but yeah :)

@YuriSizov YuriSizov merged commit 6f90b23 into godotengine:master Aug 25, 2023
15 checks passed
@YuriSizov
Copy link
Contributor

Thanks!

@aaronfranke aaronfranke deleted the fix-enter-tree branch August 25, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuriSizov YuriSizov YuriSizov approved these changes

Assignees
No one assigned
Labels
enhancement topic:codestyle topic:export
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
2 participants
@aaronfranke @YuriSizov