Add a button in the export dialog to fix missing texture formats #78457
Conversation
aaronfranke
force-pushed
the
tex-format-fix-button
branch
from
40c5c40
to
958ea49
Compare
aaronfranke
force-pushed
the
tex-format-fix-button
branch
from
958ea49
to
acf7199
Compare
|
From the discussion we had in the production meeting today I can say that this is a good improvement, but there may be some suggestions on how to adjust this new UI. So to give it a bit time to polish I'm putting it onto 4.2. #78456 should already help a lot in 4.1. |
akien-mga
requested review from
clayjohn and
YuriSizov
and removed request for
a team
There was a problem hiding this comment.
Haven't tested, just the code and style review. Overall the editor bits look fine.
Design-wise, I think we use LinkButton (or meta tags if in RTL) for such actions, though. A normal button stands out more and is easier to understand, but it also kind of looks out of place. Not a blocker though.
aaronfranke
force-pushed
the
tex-format-fix-button
branch
3 times, most recently
from
b01763f
to
5ad3883
Compare
Usually you would expect a LinkButton to, well, be a link to something, like opening a menu or web page. This button doesn't link to anything, it performs an action. A regular button makes more sense to me here. |
aaronfranke
force-pushed
the
tex-format-fix-button
branch
3 times, most recently
from
71ae7a5
to
82601cc
Compare
aaronfranke
force-pushed
the
tex-format-fix-button
branch
from
82601cc
to
ada360a
Compare
|
Updated the PR to use a LinkButton (and re-tested). 
|
|
I like the look if it. I somewhat agree with your previous statement:
But somehow it still looks nicer like this :P |
|
Thanks! |
|
|
||
| void ProjectExportTextureFormatError::_notification(int p_what) { | ||
| switch (p_what) { | ||
| case NOTIFICATION_ENTER_TREE: |
There was a problem hiding this comment.
This was excessive btw, NOTIFICATION_THEME_CHANGED already fires when the node enters the tree.
This PR improves the error message about texture formats by adding a button to fix it. I was inspired by a similar fix button in VRChat and realized the same idea would work perfectly here. This will greatly help with #78395.
When the button is pressed, the project setting is enabled, the settings are saved, the editor file system is re-scanned (which reimports all textures as needed), and the export dialog is refreshed.