Add logging when macOS export will fail due to disabled texture formats. #86769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Jan 4, 2024
StagnationPoint
force-pushed
the
logging_improvement
branch
from
3003fbb
to
45d8ec3
Compare
akien-mga
approved these changes
Jan 5, 2024
…ts. Since ETC2 ASTC is required for universal builds, also ensure it is enabled for them.
StagnationPoint
force-pushed
the
logging_improvement
branch
from
45d8ec3
to
7035cf8
Compare
AThousandShips
approved these changes
Jan 5, 2024
|
Thanks for the guidance, all! Much appreciated. |
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
aaronfranke
reviewed
Apr 9, 2024
| @@ -2051,13 +2051,17 @@ bool EditorExportPlatformMacOS::has_valid_export_configuration(const Ref<EditorE | |||
| String architecture = p_preset->get("binary_format/architecture"); | |||
| if (architecture == "universal" || architecture == "x86_64") { | |||
| if (!ResourceImporterTextureSettings::should_import_s3tc_bptc()) { | |||
| err += TTR("Cannot export for universal or x86_64 if S3TC BPTC texture format is disabled. Enable it in the Project Settings (Rendering > Textures > VRAM Compression > Import S3TC BPTC).") + "\n"; | |||
There was a problem hiding this comment.
Enable it in the Project Settings [...]
Instead of requiring the user to dig into the settings, we should just provide a button to fix it. I implemented this in PR #78457, but the button seems to have disappeared somewhere in-between my PR and your PR? It's still present for Android, but missing for macOS for some weird reason.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if a required texture format is disabled during macOS export, the export will fail without logging any information indicating the real source of the problem. This change adds error messaging that will direct the user toward the issue.