GDExtension: Delete left-over DLL copy before making a new copy #81576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 12, 2023
dsnopek
force-pushed
the
gdextension-dll-copy-failure
branch
from
7a38974
to
6554ccf
Compare
|
Works as intended. |
akien-mga
approved these changes
Sep 14, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in this comment, if Godot crashes before it can clean up the DLL copy, then it will fail to copy it again (and hence fail to load the GDExtension).
This PR will check if the DLL already exists and attempt to delete it, before attempting the copy.
It appears to work in some quick testing on Windows! Like shown in the linked comment, I'm hitting Ctrl-C shortly after starting the editor to force a crash (which leaves the copy behind), and then running the editor again until it fully loads.