Rewrite docs for physics damping project settings #82950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Talon1024
reviewed
Oct 7, 2023
|
I don't understand the concrete failure in |
|
Follow my corrections above, you have a format error |
Mickeon
approved these changes
Jan 16, 2024
|
If you can squash those commits it would be very nice. See https://docs.godotengine.org/en/stable/contributing/workflow/pr_workflow.html#the-interactive-rebase |
akien-mga
changed the title
Signed-off-by: Tiger Jove <tiger@jupiter.blue>
akien-mga
force-pushed
the
physics-damping-redocumentation
branch
from
d3a5cc4 to
7d9f6da
Compare
|
I squashed the commits, and fixed trailing spaces and the use of Windows return carriage at end of lines. |
akien-mga
changed the title
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct location for the documentation changes I erroneously submitted to sphinx.
Resolves godotengine/godot-docs#8163
Supersedes godotengine/godot-docs#8176
Physics Damping (2D and 3D) documentation was incorrect and misleading, suggesting a critical spring damping scheme (that "tries to stop a body in a given time", but it's a "negative exponential damper", that is both velocity and tick-rate dependent).
Hopefully this will save some hairs from going grey and provide a deeper understanding for the users of this obscure value and its inner workings (Godot is a bit special in this regard, though the combine feature is really cool) :)