Fix NavigationObstacle3D height #83701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes NavigationObstacle3D height.
Part of #83625.
Affected all projects that used the default height because the height setter does not send the update when the value has not changed from the default.
The NavigationObstacle3D is one of those special cases where the server object default does not match the node default. The server object is shared with 2D and 2D requires a height of zero while 3D requires a height of 1.0 so it needs that update to go through to work. With the setter not sending the update and at a height of zero the obstacle that used the default height was only working while agents were on the same y-axis as the obstacle.