Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing NavigationObstacle property updates in constructor #83816

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

smix8
Copy link
Contributor

@smix8 smix8 commented Oct 23, 2023

Fixes missing NavigationObstacle property updates in constructor.

Same as with Agents from #83814.

The imminent bug with the height setter was already fixed with #83701 but the other properties have the same issue. They only do not show up as an issue right now because the server object starts with the same default values which was not the case for the height.

Fixes missing NavigationObstacle property updates in constructor.
@smix8 smix8 added this to the 4.x milestone Oct 23, 2023
@smix8 smix8 requested review from a team as code owners October 23, 2023 03:16
@smix8 smix8 modified the milestones: 4.x, 4.3 Nov 1, 2023
@smix8 smix8 added the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Nov 1, 2023
Copy link
Contributor

@YuriSizov YuriSizov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

@akien-mga akien-mga merged commit 4ce65c6 into godotengine:master Dec 4, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@YuriSizov YuriSizov removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Dec 5, 2023
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.2.1.

@smix8 smix8 deleted the navobstacle_properties branch December 5, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants