Fix noise_direction variable used before initialized in particle shader when using turbulence with collisions
#83881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most likely because this code is older than C++11 usage in the Godot codebase, and hasn't been modernized yet. It could be changed, but since there are lots of fixes on particles code being done these days, I'd wait a bit to avoid breaking PRs and making the |
jsjtxietian
force-pushed
the
fix-generated-particle-shader-use-noise-direction-before-define
branch
from
6563e74 to
d008f2a
Compare
clayjohn
reviewed
Oct 24, 2023
jsjtxietian
force-pushed
the
fix-generated-particle-shader-use-noise-direction-before-define
branch
from
d008f2a to
f388874
Compare
akien-mga
reviewed
Oct 25, 2023
jsjtxietian
force-pushed
the
fix-generated-particle-shader-use-noise-direction-before-define
branch
from
f388874 to
80f38a3
Compare
clayjohn
reviewed
Oct 25, 2023
…ader when using turbulence with collisions, delete unused code
jsjtxietian
force-pushed
the
fix-generated-particle-shader-use-noise-direction-before-define
branch
from
80f38a3 to
cc14e00
Compare
clayjohn
approved these changes
Oct 25, 2023
|
Thanks! |
jsjtxietian
deleted the
fix-generated-particle-shader-use-noise-direction-before-define
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #83858
And why do we not use R""(Raw String Literal) to replace continuous
string +=inparticle_process_material? Much cleaner and potentially faster.