Use default samplers in base uniform set when rendering to reflection probes #84317
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #83962
The RenderBuffers used by ReflectionProbes doesn't create and maintain its own set of samplers. So basically what was happening was the Viewport RenderBuffers were invalidating the base_uniform_set (so it would get recreated with the new samplers). But then the ReflectionProbes would get rendered, and they don't have valid samplers, so they would give invalid samplers and the base_uniform_set would be null. Then rendering would fail for a frame. The Viewport would then get rendered and update the base_uniform_set to be valid. Then, in subsequent frames, the ReflectionProbes would just use the updated base_uniform_set.
This PR works, but I think it will bring us back to the state where the sampler gets ignored when changed (due to how the caching works). I need to do a bit more testing before this is ready.