Fix GLTF embedded texture not reimporting when changed #85040
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #83154
The existing code skips re-extract/reimport of the embedded texture if an existing file at the extract path doesn't have a
md5
value in theremap:generator_parameters
section of its.import
metadata, under the assumption the existing file wasn't an extracted version because it's missing it. But it wasn't writing themd5
value to the metadata when importing the first time, so this failed as a check.Though I'm not sure this is a good long-term solution to tracking whether an existing texture is an extracted texture or not. I feel there should probably be more specific metadata related to this than just an md5, like an
isExtractTexture
bool and maybe anownerUID
entry...