GLTF: Fix three bugs which prevented extracted textures from being refreshed #86504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…freshed. 1. Extracted texture paths in `GLTFDocument::_parse_image_save_image` at the project root started with res:/// which broke cache invalidation 2. md5 hashes were not being written to generator_parameters for new imports, which led Godot to think the file was manually created. 3. `EditorFileSystem::reimport_append` must emit the `resources_reimported` signal in order for the resource cache to be updated.
fire
approved these changes
Dec 28, 2023
akien-mga
changed the title
akien-mga
added
the
cherrypick:4.2
akien-mga
approved these changes
Jan 2, 2024
|
Thanks! |
akien-mga
changed the title
lyuma
added
the
cherrypick:4.1
YuriSizov
removed
the
cherrypick:4.2
|
Cherry-picked for 4.2.2. |
YuriSizov
removed
the
cherrypick:4.1
|
Cherry-picked for 4.1.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The three sub-bugs this PR addresses are:
GLTFDocument::_parse_image_save_imageat the project root started with res:/// which broke cache invalidationEditorFileSystem::reimport_appendmust emit theresources_reimportedsignal in order for the resource cache to be updated.Fixes #83154