-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance mobile suspend MainLoop notifications #85100
Enhance mobile suspend MainLoop notifications #85100
Conversation
It would be better to have the Android and iOS implementations in the same PR/commit, so that we don't risk introducing significant platform support differences. If you could only implement one, it's fine to have a PR for it, but since you did both it makes sense to land that change all at once. |
@Calinou thoughts? I don't feel strongly one way or the other here, I just want to make sure everyone is on the same page to avoid future confusion. |
I'd follow Akien's judgement here, so that it's easier to compare the Android and iOS code added in the same PR. |
dd24170
to
ac5cdf1
Compare
Merged |
APPLICATION_PAUSE
and APPLICATION_RESUMED
MainLoop Notifications
APPLICATION_PAUSE
and APPLICATION_RESUMED
MainLoop NotificationsAPPLICATION_PAUSE
and APPLICATION_RESUMED
MainLoop notifications
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Android section looks good.
Please squash your commits into one, see here |
2622b46
to
ec5ed18
Compare
Done 🙂 |
Any update on this? I believe this feature is exactly what i'm looking for in my own game, so would be great to see this merged |
APPLICATION_PAUSE
and APPLICATION_RESUMED
MainLoop notifications
The iOS part still needs to be reviewed and we don't have a dedicated iOS maintainer, so it takes some time. |
Came back from that notification and forgot I should have included the rationale for this.
The source for that claim added to the docs is this, there might be a better way to word it but that might make review a bit easier. I think this is relevant information because it would probably be hard for someone deep into a Godot project to think to check Apple's docs for |
ec5ed18
to
fc7a63c
Compare
Thanks! |
Implements godotengine/godot-proposals#8453
iOS:
Adds
NOTIFICATION_APPLICATION_RESUMED
andNOTIFICATION_APPLICATION_PAUSED
on iOS, as well as making the application being switched from also fireNOTIFICATION_APPLICATION_FOCUS_OUT
andNOTIFICATION_APPLICATION_FOCUS_IN
upon returning.Android:
Makes the application being switched from fire
NOTIFICATION_APPLICATION_FOCUS_OUT
andNOTIFICATION_APPLICATION_FOCUS_IN
upon returning.Be mindful of godotengine/godot-proposals#8453 (comment), there may be complications with DeX mode that need to be ironed out.