Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.x] Enhance mobile suspend MainLoop notifications #85229

Merged
merged 1 commit into from
Feb 7, 2024
Merged

[3.x] Enhance mobile suspend MainLoop notifications #85229

merged 1 commit into from
Feb 7, 2024

Conversation

ztc0611
Copy link
Contributor

@ztc0611 ztc0611 commented Nov 22, 2023

Backport of #85100 for 3.x. NOTIFICATION_APPLICATION_FOCUS_OUT and NOTIFICATION_APPLICATION_FOCUS_IN do not exist in 3.x, so it is just adding APP_PAUSED and APP_RESUMED to iOS.

@ztc0611 ztc0611 requested review from a team as code owners November 22, 2023 16:48
@AThousandShips AThousandShips added this to the 3.x milestone Nov 22, 2023
@ztc0611 ztc0611 force-pushed the 3.x-ios-add-pause-resume-notifs branch from b656d36 to ffe86ee Compare November 22, 2023 17:04
@AThousandShips AThousandShips changed the title [3.x][iOS] Add APP_PAUSED and APP_RESUMED MainLoop notifications [3.x][iOS] Add APP_PAUSED and APP_RESUMED MainLoop notifications Nov 22, 2023
@AThousandShips AThousandShips changed the title [3.x][iOS] Add APP_PAUSED and APP_RESUMED MainLoop notifications [3.x][Mobile] Add APP_PAUSED and APP_RESUMED MainLoop notifications Nov 22, 2023
@ztc0611 ztc0611 changed the title [3.x][Mobile] Add APP_PAUSED and APP_RESUMED MainLoop notifications [3.x] Enhance mobile suspend MainLoop notifications Dec 19, 2023
lawnjelly
lawnjelly approved these changes Feb 6, 2024
View reviewed changes
Copy link
Member

@lawnjelly lawnjelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've never touched an iOS device, but this looks plausible and fairly simple, worth a go imo.

@akien-mga akien-mga modified the milestones: 3.x, 3.6 Feb 7, 2024
@akien-mga akien-mga merged commit 273d589 into godotengine:3.x Feb 7, 2024
13 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AThousandShips AThousandShips AThousandShips approved these changes

@lawnjelly lawnjelly lawnjelly approved these changes

Assignees
No one assigned
Labels
enhancement platform:android platform:ios topic:porting
Projects
None yet
Milestone
3.6
Development

Successfully merging this pull request may close these issues.
4 participants
@ztc0611 @akien-mga @lawnjelly @AThousandShips