Correctly emit sub-emitter's emission at the end #85189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Nov 22, 2023
akien-mga
changed the title
|
Remember to capitalize your commit messages ;) |
QbieShay
force-pushed
the
qbe/fix-emission-at-end
branch
2 times, most recently
from
cd77faa to
f2409b0
Compare
akien-mga
reviewed
Nov 23, 2023
akien-mga
added
the
cherrypick:4.2
QbieShay
force-pushed
the
qbe/fix-emission-at-end
branch
from
f2409b0 to
4d390cd
Compare
YuriSizov
changed the title
clayjohn
approved these changes
Apr 30, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Particles were previously arbitrarily emitting "at end" at 95% of lifetime. Probably worked ok for most particles, but for long living particles it's really really visible.