Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable non-multiview advanced shader group whenever advanced shaders are requested #85194

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Enable non-multiview advanced shader group whenever advanced shaders are requested #85194

merged 1 commit into from
Nov 22, 2023

Conversation

clayjohn
Copy link
Member

Fixes: #84999

This is needed because xr_enabled does not guarantee that we won't use the non-multiview variants

@clayjohn
Enable non-multiview advanced shader group whenever advanced shaders …
e2a5d2b 
…are requested

This is needed because xr_enabled does not guarantee that we won't use the non-multiview variants
@clayjohn clayjohn added this to the 4.2 milestone Nov 21, 2023
@clayjohn clayjohn requested a review from a team as a code owner November 21, 2023 22:17
BastiaanOlij
BastiaanOlij approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@BastiaanOlij BastiaanOlij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Owh very important indeed, I didn't realise SHADER_GROUP_ADVANCED_MULTIVIEW ignores the non-multiview ones.

Even in VR games we can render things to subviewports that are not multiview.

@akien-mga akien-mga merged commit 1faf2f5 into godotengine:master Nov 22, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@dreadpon
Copy link

Thank you, the reproduction project is working smoothly!
Might start testing this fix in the actual project in the coming days

@clayjohn clayjohn deleted the XR-pipeline-bug branch November 28, 2023 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BastiaanOlij BastiaanOlij BastiaanOlij approved these changes

Assignees
No one assigned
Labels
bug regression topic:rendering topic:shaders
Projects
None yet
Milestone
4.2
4 participants
@clayjohn @akien-mga @dreadpon @BastiaanOlij