Set ReflectionProbe frame before mapping id in mobile renderer #85635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clayjohn
added
the
cherrypick:4.2
akien-mga
approved these changes
Dec 2, 2023
|
Strange indeed because reflection probes definitely worked on the mobile renderer at some point.. Anyway, good find! |
BastiaanOlij
approved these changes
Dec 4, 2023
|
Thanks! |
|
Cherry-picked for 4.2.1. |
YuriSizov
removed
the
cherrypick:4.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an unreported regression from #83493
The
last_passof the ReflectionProbe was set after mapping the ID. Which means that it was always out of date, resulting in the ReflectionProbe being culled at draw time.I'm very surprised that this hasn't been reported as it totally breaks ReflectionProbes in the mobile renderer.
Bugsquad edit: