Add event_index to InputEventAction
#86010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoBeWi
commented
Dec 10, 2023
KoBeWi
force-pushed
the
input,_event,_action!
branch
2 times, most recently
from
d3fc6ba
to
f0ec342
Compare
akien-mga
reviewed
Dec 11, 2023
KoBeWi
force-pushed
the
input,_event,_action!
branch
from
f0ec342
to
fa3b3ee
Compare
|
Could use a rebase for good measure. If/when merged, how confident are we in cherry-picking this for 4.2.3 to fix the regression? Or should we keep it for 4.3 only? |
KoBeWi
force-pushed
the
input,_event,_action!
branch
from
fa3b3ee
to
7fe93b1
Compare
KoBeWi
force-pushed
the
input,_event,_action!
branch
from
7fe93b1
to
97b50de
Compare
groud
approved these changes
May 30, 2024
KoBeWi
force-pushed
the
input,_event,_action!
branch
from
97b50de
to
17d3f26
Compare
KoBeWi
changed the title
event_id to InputEventActionevent_index to InputEventAction
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #85984
Since #84685 actions rely on event id to press/release action. However InputEventAction does not correspond to any event, so it needed special handling. We could hard-code an event ID, but I thought it would be more useful to allow specifying which device the virtual event corresponds to.