Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add event_index to InputEventAction #86010

Merged
merged 1 commit into from
May 30, 2024

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Dec 10, 2023

Fixes #85984

Since #84685 actions rely on event id to press/release action. However InputEventAction does not correspond to any event, so it needed special handling. We could hard-code an event ID, but I thought it would be more useful to allow specifying which device the virtual event corresponds to.

core/input/input.cpp Outdated Show resolved Hide resolved
@KoBeWi KoBeWi force-pushed the input,_event,_action! branch 2 times, most recently from d3fc6ba to f0ec342 Compare December 11, 2023 13:04
@KoBeWi KoBeWi marked this pull request as ready for review December 11, 2023 13:06
@KoBeWi KoBeWi requested review from a team as code owners December 11, 2023 13:06
@KoBeWi KoBeWi force-pushed the input,_event,_action! branch from f0ec342 to fa3b3ee Compare December 11, 2023 13:51
@akien-mga
Copy link
Member

Could use a rebase for good measure.

If/when merged, how confident are we in cherry-picking this for 4.2.3 to fix the regression? Or should we keep it for 4.3 only?

@KoBeWi KoBeWi force-pushed the input,_event,_action! branch from fa3b3ee to 7fe93b1 Compare April 6, 2024 10:29
@akien-mga akien-mga requested review from a team and removed request for kitbdev May 7, 2024 13:12
@KoBeWi KoBeWi force-pushed the input,_event,_action! branch from 7fe93b1 to 97b50de Compare May 30, 2024 10:39
@KoBeWi KoBeWi force-pushed the input,_event,_action! branch from 97b50de to 17d3f26 Compare May 30, 2024 10:51
@KoBeWi KoBeWi changed the title Add event_id to InputEventAction Add event_index to InputEventAction May 30, 2024
@akien-mga akien-mga merged commit 0600925 into godotengine:master May 30, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simulating keypresses 4.1->4.2 regression
6 participants