Fix selecting popup menu items on mouse release (reverted) #86952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryevdokimov
force-pushed
the
fix-selecting-popup-menu-items-on-mouse-release
branch
2 times, most recently
from
a335fba to
077a756
Compare
ryevdokimov
force-pushed
the
fix-selecting-popup-menu-items-on-mouse-release
branch
from
077a756 to
a1cee91
Compare
|
Something messed up with selecting checkboxes, looking into it. |
ryevdokimov
force-pushed
the
fix-selecting-popup-menu-items-on-mouse-release
branch
from
a1cee91 to
f4ba44c
Compare
|
Ok, fixed and works with checkboxes now.
|
ryevdokimov
force-pushed
the
fix-selecting-popup-menu-items-on-mouse-release
branch
6 times, most recently
from
9411c07 to
ed14d3e
Compare
KoBeWi
reviewed
Jan 14, 2024
ryevdokimov
force-pushed
the
fix-selecting-popup-menu-items-on-mouse-release
branch
from
ed14d3e to
576d281
Compare
|
Bug: mouse wheel will select options, making it impossible to scroll long lists. |
ryevdokimov
force-pushed
the
fix-selecting-popup-menu-items-on-mouse-release
branch
2 times, most recently
from
96c5eb9 to
2892938
Compare
ryevdokimov
force-pushed
the
fix-selecting-popup-menu-items-on-mouse-release
branch
from
2892938 to
06c2cda
Compare
|
Good catch, it's fixed now. |
KoBeWi
approved these changes
Jan 19, 2024
|
Thanks! |
ryevdokimov
deleted the
fix-selecting-popup-menu-items-on-mouse-release
branch
This was referenced Feb 19, 2024
akien-mga
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure this ever worked, since I don't think InputEventMouseButton registers in windows on mouse up and messing with the input code is probably a bad idea unless there is a very good reason.
This PR should fix it though. Regular mouse click behavior is maintained (keep menu open).