Remove the ability to open the top popup menus with right-click

[ryevdokimov]

Related to #86952

This is kind of a weird behavior and is pretty none-standard across software I've seen. It also leads to weird bugs, where you can right click select check boxes, but only when the popup menu was opened with a right-click.

[lostminds]

On macOS you can open native top bar menus (and select items) with either left or right mouse button. While most users probably use left button I don't see the benefit of not allowing using the right mouse button for opening menus if someone prefers that. However, when I test it in the 4.2.1 editor the embedded godot menus there only seems to support opening with left mouse already?

If you'd like to block opening menus with right-click, perhaps something like the BaseButton button_mask property could be a better solution, that way the user can configure what mouse buttons should be supported in a consistent way.

[AThousandShips]

This should probably be discussed more in depth on a proposal about what way to go and the interest in such a change, it does break compatibility IMO as it removes existing features that people might use or want

[ryevdokimov]

This should probably be discussed more in depth on a proposal about what way to go and the interest in such a change, it does break compatibility IMO as it removes existing features that people might use or want

Hmm, this is technically a bug (or several) as well then. What I'm understanding and/or know is:

On mac the top menus can only open with left click, but mac users expect to be able to open and select with either?

On windows you can open with a right click, but it's janky as it allows you to subsequently select an item with right click, but only once.

On windows as well, you can't open these popup menus with a right-click, so the behavior isn't consistent in the editor node.

So, at least this PR would make the behavior consistent across the editor node, across platforms (I think?), and prevent some side effects. In terms of compatibility, it's hard to say with the points above, since users aren't given a consistent experience. Not sure, it's a weird situation.

[AThousandShips]

The menu bars in the engine doesn't have to match the system ones, and those other menus are not the same kind, so that's not really relevant to changing these, as in treating this as a bug, lack of consistency isn't a bug necessarily, that's why this needs to be discussed, this might not be the solution to this inconsistency, or a solution might not be desired at all

Also this isn't just about the editor, so we have to consider all uses of the menu bar node

[ryevdokimov]

The menu bars in the engine doesn't have to match the system ones, and those other menus are not the same kind, so that's not really relevant to changing these, as in treating this as a bug, lack of consistency isn't a bug necessarily, that's why this needs to be discussed, this might not be the solution to this inconsistency, or a solution might not be desired at all

Also this isn't just about the editor, so we have to consider all uses of the menu bar node

Good points. I'll think about this more.

[Sauermann]

Related to #80346 and godotengine/godot-proposals#7463