Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Namespace shader cache files by graphics API #87796

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Namespace shader cache files by graphics API #87796

merged 1 commit into from
Feb 12, 2024

Conversation

RandomShaper
Copy link
Member

@RandomShaper RandomShaper commented Jan 31, 2024 •
edited by akien-mga
Loading

Namely, cache files now end with .d3d12.cache or .vulkan.cache instead of just .cache. This avoids the whole shader cache from being invalidated (and thus regenerated) when switching rendering drivers.

@RandomShaper RandomShaper added this to the 4.3 milestone Jan 31, 2024
@RandomShaper RandomShaper requested a review from a team as a code owner January 31, 2024 19:15
@clayjohn clayjohn added the bug label Feb 9, 2024
@akien-mga akien-mga merged commit f12d737 into godotengine:master Feb 12, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@RandomShaper RandomShaper deleted the shader_cache_split branch February 12, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clayjohn clayjohn clayjohn approved these changes

Assignees
No one assigned
Labels
bug enhancement topic:rendering
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@RandomShaper @akien-mga @clayjohn