Fix crash during import bone remap.

[tdaven]

The HashMap being used by can fail to find a bone to remap which will result in a crash since the HashMap is const.

Use the find method on the hashmap to loop values and gracefully handle the failure to find the bone instead of crashing.

Fixes: #87904

[AThousandShips]

While it shouldn't crash the fact that it didn't already use a permissive check makes me think this should cause an error instead and abort importing

[tdaven]

I suspect that would change previous behavior where it would rename/remap the bones it couldn't match and not the others which might break peoples import workflows.

[AThousandShips]

No previous behaviour would change though would it? It'd just crash before, I mean specifically when the original crash condition occurs?

[tdaven]

Prior to 96a95cb this worked just fine and didn't crash either.

[AThousandShips]

Wasn't aware of that part, but that was a case where it shouldn't have manipulated the map anyway so no intentional behaviour was changed

The map is intentionally filled with valid entries and then previously copied, so the values weren't supposed to be added I'd say

Id suspect the previous copy instead of passing as const was an oversight, which was exposed by that change

But I'm not sure, we'll see what the relevant teams say 🙂

[tdaven]

I suspect we don't want to warn. I partially only added them to confirm it was working but hey are a bit too verbose. Maybe only in dev builds or if at all.

[tdaven]

Adding MRP to help in getting this merged at some point.

bone-remap-mrp.zip

[fire]

@TokageItLab if you want to review.

[tdaven]

I don't believe t his PR is needed anymore. The merging of #81746 included the same type of changes(using the find methods on the hashmap).

[akien-mga]

Thanks for the contribution!