Fix crash when there is no bones to rename when retargeting an imported skeleton #88109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wonder if #87905 would also fix this. |
|
@tdaven Tested it and it does fix the issue. |
|
Does the other pr supersede this one? |
|
I think so since this only works when the map is empty where the other PR prevents bad lookups on a const HashMap with '[]' which purposely crashes but I was going to leave that decision up to a reviewer. |
|
Sounds good to me. Anything as long as retargeting is working. |
|
Crash fixed with the merging of #81746 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #88086