Clean up and optimize BasisUniversal #88464
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to clean up BasisUniversal's code to make it easier to read, as well as extracts the code from
register_types.cpp
into its own files.It also slightly optimizes the memory usage and compression times by using the
get_mipmap_offset_size_and_dimensions()
function instead of copying each mipmap's data into a new image.While it seems to function correctly, it still needs some testing, especially on mobile devices.