Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ASTC support to BasisUniversal #88485

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

BlueCube3310
Copy link
Contributor

@BlueCube3310 BlueCube3310 commented Feb 18, 2024

Depends on #88464
Closes godotengine/godot-proposals#6357

Adds ASTC unpacking support to the BasisUniversal module.
This needs more testing on mobile devices, although having tried it out myself it seems to work correctly.

astc

Small testing project:
BasisuASTC.zip

@BlueCube3310 BlueCube3310 marked this pull request as ready for review February 19, 2024 16:39
Copy link
Member

@fire fire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code review is good, but I don't have a setup for testing mobile at this current moment.

@Calinou
Copy link
Member

Calinou commented Feb 21, 2024

Tested locally, I can only get it to show up as BPTC_RGBA on my Samsung Galaxy Z Fold4:

texture webp

This is after enabling the Import ETC2/ASTC project setting and removing the .godot folder to force reimporting all resources. Both the editor and Android export template were recompiled.

@BlueCube3310
Copy link
Contributor Author

That happens because bptc has a higher priority than astc, which means it gets chosen first if available. It looks like some mobile GPUs support bptc, so they will default to that instead.

@akien-mga akien-mga modified the milestones: 4.x, 4.3 Feb 22, 2024
@akien-mga akien-mga merged commit c3de771 into godotengine:master Feb 22, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@BlueCube3310 BlueCube3310 deleted the basisu-astc-v2 branch November 28, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make basisu in godot engine unpack to astc
5 participants