Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Physics] Fix exporting with 3D disabled #88668

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

AThousandShips
Copy link
Member

@AThousandShips AThousandShips commented Feb 22, 2024

Regression from:

Unsure if these are all the relevant areas that need guarding (and the test side is a bit broken already with templates, will check more later about testing and exported projects in total, but that's not caused by these changes)

The physics server simply won't work and can't be used when not enabled or created, we could add some kind of dummy server but I think that's a lower priority thing, this makes it possible to export with 3D disabled again

An alternative would also be to simply revert #79185 but I think it has its value


@AThousandShips AThousandShips added this to the 4.3 milestone Feb 22, 2024
@AThousandShips AThousandShips requested a review from a team February 22, 2024 14:26
@AThousandShips AThousandShips requested review from a team as code owners February 22, 2024 14:26
@AThousandShips AThousandShips changed the title [Physics] Fix physics with 3D disabled [Physics] Fix exporting with 3D disabled Feb 22, 2024
@AThousandShips AThousandShips marked this pull request as draft February 22, 2024 15:13
@AThousandShips
Copy link
Member Author

Found another place where this is needed, will do another sweep

@AThousandShips AThousandShips marked this pull request as ready for review February 22, 2024 15:24
@akien-mga akien-mga merged commit 4b543dd into godotengine:master Feb 22, 2024
16 checks passed
@AThousandShips AThousandShips deleted the no_3d_fix branch February 22, 2024 15:44
@akien-mga
Copy link
Member

Thanks!

@AThousandShips
Copy link
Member Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The export template compiled with "disable_3d=true" failed to start.
2 participants