Disable registering 3D physics types when 3D is disabled #79185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronfranke
force-pushed
the
reg-phys-3d
branch
from
29ebe64
to
4d28343
Compare
aaronfranke
force-pushed
the
reg-phys-3d
branch
from
4d28343
to
ee2fbf2
Compare
aaronfranke
force-pushed
the
reg-phys-3d
branch
from
ee2fbf2
to
7dc4b30
Compare
aaronfranke
force-pushed
the
reg-phys-3d
branch
from
7dc4b30
to
7cd9455
Compare
aaronfranke
force-pushed
the
reg-phys-3d
branch
from
7cd9455
to
7a0382a
Compare
aaronfranke
force-pushed
the
reg-phys-3d
branch
from
7a0382a
to
2d1d536
Compare
akien-mga
reviewed
Feb 22, 2024
akien-mga
reviewed
Feb 22, 2024
akien-mga
approved these changes
Feb 22, 2024
aaronfranke
force-pushed
the
reg-phys-3d
branch
from
2d1d536
to
c0caf55
Compare
akien-mga
reviewed
Feb 22, 2024
aaronfranke
force-pushed
the
reg-phys-3d
branch
from
c0caf55
to
eb019e2
Compare
akien-mga
approved these changes
Feb 22, 2024
|
Thanks! |
|
This caused a regression, looking into a fix right now: |
|
Apologies for the regression, I try to test these PRs thoroughly when I make them but it can be hard to keep up with testing after rebasing. I'm glad it was resolved quickly though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR organizes the 2D and 3D physics code in
register_server_types.cppand allows the 3D physics type registration code to be disabled by wrapping it in#ifndef _3D_DISABLED.In the current master, a macOS arm64 template_release build is 66.5 MB (66503407 bytes). Using
disable_3d=yesbrings this down to 60.2 MB (60224255 bytes), a reduction of 9.4%.With this PR, the
disable_3d=yesbuild is 58.8 MB (58848751 bytes), a reduction of 2.3% compared to master with this option, and brings the total savings from 9.4% to 11.5% compared to 3D enabled, a reduction of 2.1%.