Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Fix casing of some C# names #89710

Merged
1 commit merged into from
Mar 24, 2024
Merged

Conversation

AThousandShips
Copy link
Member

I think I got them all, hard to identify exactly everything

@AThousandShips AThousandShips added bug documentation cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Mar 20, 2024
@AThousandShips AThousandShips added this to the 4.3 milestone Mar 20, 2024
@AThousandShips AThousandShips requested a review from a team as a code owner March 20, 2024 12:40
@AThousandShips AThousandShips requested a review from a team March 20, 2024 13:55
Copy link
Member

@paulloz paulloz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of the new names are correct 👍

Copy link
Contributor

@skyace65 skyace65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the names look correct!

@akien-mga akien-mga closed this pull request by merging all changes into godotengine:master in 06abc86 Mar 24, 2024
akien-mga added a commit that referenced this pull request Mar 24, 2024
@akien-mga
Copy link
Member

Thanks!

@AThousandShips AThousandShips deleted the dotnet_names branch March 24, 2024 08:44
@AThousandShips
Copy link
Member Author

Thank you!

@akien-mga
Copy link
Member

Cherry-picked for 4.2.2.

@akien-mga akien-mga removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Apr 8, 2024
@akien-mga
Copy link
Member

Cherry-picked for 4.1.4.

@akien-mga akien-mga removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InputEventMIDI is incorrectly written InputEventMidi (upper case MIDI instead of Midi)
4 participants