-
-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Native File Dialog] Add support for using native dialogs in the editor. #89735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoBeWi
reviewed
Mar 25, 2024
KoBeWi
reviewed
Mar 25, 2024
KoBeWi
reviewed
Mar 25, 2024
KoBeWi
reviewed
Mar 25, 2024
KoBeWi
reviewed
Mar 25, 2024
KoBeWi
reviewed
Mar 25, 2024
KoBeWi
reviewed
Mar 25, 2024
KoBeWi
reviewed
Mar 25, 2024
KoBeWi
reviewed
Mar 25, 2024
bruvzg
force-pushed
the
ed_native_fd2
branch
2 times, most recently
from
March 26, 2024 06:59
2de0dd5
to
c0d9525
Compare
KoBeWi
reviewed
Mar 26, 2024
@@ -59,6 +59,17 @@ void FileDialog::_focus_file_text() { | |||
} | |||
} | |||
|
|||
void FileDialog::_native_popup() { | |||
// Show native dialog directly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this comment relevant here?
KoBeWi
approved these changes
Mar 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now.
Thanks! |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for using native dialogs in the editor, in case #79313 used by #79316 UI, export options are shown as a separate dialog before showing native file dialog.
EditorFileDialog
.EditorFileDialog
(same as in the normalFileDialog
) and use it instead of custom checkboxes in the various editor places.interface/editor/use_native_file_dialogs
editor setting to enable native dialogs (also automatically enabled if editor is sandboxed).