Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Native File Dialog] Add support for using native dialogs in the editor. #89735

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Mar 21, 2024

Add support for using native dialogs in the editor, in case #79313 used by #79316 UI, export options are shown as a separate dialog before showing native file dialog.

  • Adds support for using native dialogs to the EditorFileDialog.
  • Adds support for custom options to the EditorFileDialog (same as in the normal FileDialog) and use it instead of custom checkboxes in the various editor places.
  • Adds interface/editor/use_native_file_dialogs editor setting to enable native dialogs (also automatically enabled if editor is sandboxed).

editor/editor_node.cpp Outdated Show resolved Hide resolved
scene/gui/file_dialog.cpp Outdated Show resolved Hide resolved
@bruvzg bruvzg force-pushed the ed_native_fd2 branch 2 times, most recently from 2de0dd5 to c0d9525 Compare March 26, 2024 06:59
@@ -59,6 +59,17 @@ void FileDialog::_focus_file_text() {
}
}

void FileDialog::_native_popup() {
// Show native dialog directly.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this comment relevant here?

Copy link
Member

@KoBeWi KoBeWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now.

@akien-mga akien-mga modified the milestones: 4.x, 4.3 Mar 26, 2024
@akien-mga akien-mga merged commit 27dec32 into godotengine:master Apr 4, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants