[Native File Dialog] Add support for adding custom options to the dialogs. #83480

bruvzg · 2023-10-17T07:02:28Z

Add support for adding custom options (checkboxes and optionboxes) to the dialogs (both native and built-in).
Add support for using native dialogs in the editor.

Screenshots

Related proposal: godotengine/godot-proposals#1123
Fixes #86351

Calinou

Tested locally on Linux (KDE), it works as expected.

Load

Save

akien-mga · 2024-01-09T12:30:20Z

Will need a rebase, and filling the documentation.

KoBeWi · 2024-01-13T18:06:01Z

editor/editor_settings.cpp

@@ -413,6 +413,7 @@ void EditorSettings::_load_defaults(Ref<ConfigFile> p_extra_config) {
 	set_restart_if_changed("interface/editor/debug/enable_pseudolocalization", true);
 	// Use pseudolocalization in editor.
 	EDITOR_SETTING_USAGE(Variant::BOOL, PROPERTY_HINT_NONE, "interface/editor/use_embedded_menu", false, "", PROPERTY_USAGE_DEFAULT | PROPERTY_USAGE_RESTART_IF_CHANGED)
+	EDITOR_SETTING_USAGE(Variant::BOOL, PROPERTY_HINT_NONE, "interface/editor/use_native_file_dialogs", false, "", PROPERTY_USAGE_DEFAULT)


Any plans to enable it by default?
EDIT:
nvm, seems like it's not fully functional yet.

Seems like all editor problems were resolved, so this can be enabled by default to get more testing.
Though might be worth double-checking if it behaves correctly on unsupported platforms too.

KoBeWi · 2024-01-13T19:19:29Z

scene/gui/file_dialog.cpp

+		Node *child = grid_options->get_child(0);
+		grid_options->remove_child(child);
+		child->queue_free();


Pretty sure you can just do memdelete().

Every similar instance seems to be using queue_free().

editor/gui/editor_file_dialog.cpp

bruvzg · 2024-01-13T22:25:18Z

Adding, removing or editing options in the FileDialog do not update it immediately. You need to toggle visibility for it to have effect. I think it would be useful to update the values immediately, at least in the editor, so you can preview the dialog in realtime.

This can't be done with the native dialogs, there's no way to control it after showing (in case of macOS and Linux, native dialogs are show by completely different process to access file system outside sandbox).

Also native dialog for opening scenes does not show at all.

I can't reproduce it.

Seems like it's a problem with all file saving (event export).

It's a pre-existing issue with the native dialogs (#86351), should be fixed now.

KoBeWi · 2024-01-13T22:26:48Z

This can't be done with the native dialogs, there's no way to control it after showing

I don't mean native dialogs. I mean a FileDialog placed in the editor. It doesn't update, you need to hide/show it.

I can't reproduce it.

I'm using Windows 10 if that matters.

bruvzg · 2024-01-13T22:37:50Z

I don't mean native dialogs. I mean a FileDialog placed in the editor. It doesn't update, you need to hide/show it.

Ah, I see. It should update now.

I'm using Windows 10 if that matters.

I'll re-check it on Windows a bit later.

KoBeWi · 2024-01-15T20:32:54Z

Restested. Scene dialogs are now working correctly, saving is still wrong. It does add extension, but a wrong one, e.g. saving tscn file will make scn.

bruvzg · 2024-01-15T20:44:53Z

It does add extension, but a wrong one, e.g. saving tscn file will make scn.

Rechecked Windows API docs, seems like it's using one-based index for file filter return, should be fixed now.

YuriSizov · 2024-01-17T16:26:02Z

Add support for using native dialogs in the editor.

So this conflicts with this feature: #79313 used by #79316.

I don't think we can expose it as a setting if we rely on these custom layouts for UX, and we definitely cannot enable it by default.

bruvzg · 2024-01-17T16:28:57Z

#79313 used by #79316.

That's definitely impossible to implement in the native dialogs (at least on Linux, on Windows and macOS we can add any standard OS controls).

YuriSizov · 2024-01-17T16:31:15Z

That's definitely impossible to implement in the native dialogs.

Yeah, exactly my point. So if we want to offer this kind of user experience, I don't think we can provide native dialogs as a feature for the editor.

Edit: An option could be to redesign the flow so you configure these options before we show the file dialog. But I got to admit, based on my experience with Blender, having it on the same screen is very convenient.

ssokolow · 2024-01-17T16:46:01Z

As a data point in the other direction, I'd give up that proposed workflow in a heartbeat if it meant having my KDE Places (bookmarks) sidebar present and Just Working™... and that's before you count how I use Flatpak specifically so I can customize and lock down my sandboxing easily.

bruvzg · 2024-01-17T17:05:29Z

For the reference, I have opened separate PR with non-editor changes only - #87303

Personally, I would prefer native dialogs over this sidebar UI, but I'm not sure what would be the best replacement for it.

doc/classes/EditorFileDialog.xml

doc/classes/FileDialog.xml

Closes #274 and implements #568, at long last! Some issues remain: - The native save pxo dialog doesn't have an "Include blended images" option. This will be fixed once godotengine/godot#83480 is merged. - When a native file dialog closes, the interface still remains dimmed. - In the export dialog, the "Browse" file dialog will also close the export dialog itself when it closes, when it's native.

…logs. Add support for adding custom options (checkboxes and optionboxes) to the dialogs (both native and built-in). Add support for using native dialogs in the editor.

bruvzg · 2024-03-21T08:48:20Z

Superseded by #87303 and #89735.

bruvzg added enhancement platform:windows platform:linuxbsd platform:macos topic:editor usability topic:gui labels Oct 17, 2023

bruvzg added this to the 4.x milestone Oct 17, 2023

bruvzg force-pushed the fd_options branch 2 times, most recently from 15ea03b to cbca7ac Compare October 17, 2023 07:52

bruvzg force-pushed the fd_options branch from cbca7ac to c55c7b9 Compare October 29, 2023 18:24

bruvzg marked this pull request as ready for review October 29, 2023 19:04

bruvzg requested review from a team as code owners October 29, 2023 19:04

bruvzg force-pushed the fd_options branch from c55c7b9 to 1179b60 Compare December 4, 2023 06:58

Calinou reviewed Dec 7, 2023

View reviewed changes

akien-mga modified the milestones: 4.x, 4.3 Dec 7, 2023

akien-mga requested review from KoBeWi and YuriSizov January 9, 2024 12:29

bruvzg force-pushed the fd_options branch from 1179b60 to dd65579 Compare January 9, 2024 13:01

KoBeWi reviewed Jan 13, 2024

View reviewed changes

editor/gui/editor_file_dialog.cpp Outdated Show resolved Hide resolved

This comment was marked as resolved.

Sign in to view

bruvzg force-pushed the fd_options branch from dd65579 to cd68264 Compare January 13, 2024 22:24

bruvzg force-pushed the fd_options branch 2 times, most recently from 47292d5 to e57d34a Compare January 13, 2024 22:37

bruvzg force-pushed the fd_options branch 2 times, most recently from 50dcf09 to b4dc13b Compare January 15, 2024 20:44

KoBeWi approved these changes Jan 15, 2024

View reviewed changes

bruvzg mentioned this pull request Jan 17, 2024

[Native File Dialog] Add support for adding custom options to the dialogs (w/o editor changes). #87303

Merged

AThousandShips reviewed Jan 19, 2024

View reviewed changes

bruvzg force-pushed the fd_options branch from b4dc13b to 50905dd Compare January 25, 2024 15:38

bruvzg requested a review from a team as a code owner January 25, 2024 15:38

[Native File Dialog] Add support for adding custom options to the dia…

b1e0170

…logs. Add support for adding custom options (checkboxes and optionboxes) to the dialogs (both native and built-in). Add support for using native dialogs in the editor.

bruvzg force-pushed the fd_options branch from 50905dd to b1e0170 Compare January 25, 2024 15:39

bruvzg closed this Mar 21, 2024

bruvzg added the archived label Mar 21, 2024

AThousandShips removed this from the 4.3 milestone Mar 21, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Native File Dialog] Add support for adding custom options to the dialogs. #83480

[Native File Dialog] Add support for adding custom options to the dialogs. #83480

bruvzg commented Oct 17, 2023 •

edited

Loading

Calinou left a comment

akien-mga commented Jan 9, 2024

KoBeWi Jan 13, 2024 •

edited

Loading

KoBeWi Jan 15, 2024

KoBeWi Jan 13, 2024 •

edited

Loading

bruvzg Jan 13, 2024

This comment was marked as resolved.

bruvzg commented Jan 13, 2024

KoBeWi commented Jan 13, 2024 •

edited

Loading

bruvzg commented Jan 13, 2024

KoBeWi commented Jan 15, 2024

bruvzg commented Jan 15, 2024

YuriSizov commented Jan 17, 2024

bruvzg commented Jan 17, 2024 •

edited

Loading

YuriSizov commented Jan 17, 2024 •

edited

Loading

ssokolow commented Jan 17, 2024

bruvzg commented Jan 17, 2024

bruvzg commented Mar 21, 2024

[Native File Dialog] Add support for adding custom options to the dialogs. #83480

[Native File Dialog] Add support for adding custom options to the dialogs. #83480

Conversation

bruvzg commented Oct 17, 2023 • edited Loading

Calinou left a comment

Choose a reason for hiding this comment

Load

Save

akien-mga commented Jan 9, 2024

KoBeWi Jan 13, 2024 • edited Loading

Choose a reason for hiding this comment

KoBeWi Jan 15, 2024

Choose a reason for hiding this comment

KoBeWi Jan 13, 2024 • edited Loading

Choose a reason for hiding this comment

bruvzg Jan 13, 2024

Choose a reason for hiding this comment

This comment was marked as resolved.

bruvzg commented Jan 13, 2024

KoBeWi commented Jan 13, 2024 • edited Loading

bruvzg commented Jan 13, 2024

KoBeWi commented Jan 15, 2024

bruvzg commented Jan 15, 2024

YuriSizov commented Jan 17, 2024

bruvzg commented Jan 17, 2024 • edited Loading

YuriSizov commented Jan 17, 2024 • edited Loading

ssokolow commented Jan 17, 2024

bruvzg commented Jan 17, 2024

bruvzg commented Mar 21, 2024

bruvzg commented Oct 17, 2023 •

edited

Loading

KoBeWi Jan 13, 2024 •

edited

Loading

KoBeWi Jan 13, 2024 •

edited

Loading

KoBeWi commented Jan 13, 2024 •

edited

Loading

bruvzg commented Jan 17, 2024 •

edited

Loading

YuriSizov commented Jan 17, 2024 •

edited

Loading