SCons: Refactor selected_platform conditional
#90214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
approved these changes
Apr 4, 2024
|
Thanks! |
akien-mga
added a commit
that referenced
this pull request
Apr 5, 2024
It gives: > SyntaxError: f-string expression part cannot include a backslash Follow-up to #90214.
akien-mga
reviewed
Apr 5, 2024
| elif selected_platform != "list": | ||
| print(f'Invalid target platform "{selected_platform}".') | ||
|
|
||
| print(f"The following platforms are available:\n\t{'\n\t'.join(platform_list)}\n") |
There was a problem hiding this comment.
For the record, this doesn't seem to be legal in Python 3.10. So I fixed it up in 7e4c150 (and IMO that's more readable anyway ;)).
DanielSnd
pushed a commit
to DanielSnd/godot
that referenced
this pull request
Apr 10, 2024
It gives: > SyntaxError: f-string expression part cannot include a backslash Follow-up to godotengine#90214.
divshekhar
pushed a commit
to divshekhar/godot
that referenced
this pull request
Apr 23, 2024
It gives: > SyntaxError: f-string expression part cannot include a backslash Follow-up to godotengine#90214.
MewPurPur
pushed a commit
to MewPurPur/godot
that referenced
this pull request
Jul 11, 2024
It gives: > SyntaxError: f-string expression part cannot include a backslash Follow-up to godotengine#90214.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Realized that well over half of
SConstructhas logic behind aselected_platformconditional that could've been resolved ahead of time. By consolidating the "else" logic to directly afterselected_platformis finalized, this removes the conditional & cleans up other checks as a consequence of said conditional. I recommend hiding whitespace changes when checking diffs, as there's a lot of indentation noise otherwise.