Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some unused SceneTree properties #90598

Merged
merged 1 commit into from
Apr 13, 2024

Conversation

berarma
Copy link
Contributor

@berarma berarma commented Apr 12, 2024

This is merely clean up work. While reading the code I've found some SceneTree properties doing nothing really. Probably remains from previous versions.

@berarma berarma requested a review from a team as a code owner April 12, 2024 23:06
@smix8 smix8 added this to the 4.x milestone Apr 12, 2024
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks.

I checked the history and:

  • root_lock was never used since Godot was open sourced
  • tree_version stopped being used in d61b91c
  • processing was added in 98c655e but then not used in the end

@akien-mga akien-mga modified the milestones: 4.x, 4.3 Apr 13, 2024
@akien-mga akien-mga merged commit a66bc02 into godotengine:master Apr 13, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

@berarma
Copy link
Contributor Author

berarma commented Apr 13, 2024

Thanks! 😃

@berarma berarma deleted the scene_tree_clean_up branch April 13, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants