Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some unused SceneTree properties #90598

Merged
merged 1 commit into from
Apr 13, 2024
Merged

Remove some unused SceneTree properties #90598

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions scene/main/scene_tree.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,6 @@ void SceneTreeTimer::release_connections() {
SceneTreeTimer::SceneTreeTimer() {}

void SceneTree::tree_changed() {
tree_version++;
emit_signal(tree_changed_name);
}

Expand Down Expand Up @@ -153,7 +152,6 @@ SceneTree::Group *SceneTree::add_to_group(const StringName &p_group, Node *p_nod

ERR_FAIL_COND_V_MSG(E->value.nodes.has(p_node), &E->value, "Already in group: " + p_group + ".");
E->value.nodes.push_back(p_node);
//E->value.last_tree_version=0;
E->value.changed = true;
return &E->value;
}
Expand Down Expand Up @@ -476,8 +474,6 @@ void SceneTree::iteration_prepare() {
}

bool SceneTree::physics_process(double p_time) {
root_lock++;

current_frame++;

flush_transform_notifications();
Expand All @@ -501,7 +497,6 @@ bool SceneTree::physics_process(double p_time) {
process_tweens(p_time, true);

flush_transform_notifications();
root_lock--;

_flush_delete_queue();
_call_idle_callbacks();
Expand All @@ -510,8 +505,6 @@ bool SceneTree::physics_process(double p_time) {
}

bool SceneTree::process(double p_time) {
root_lock++;

if (MainLoop::process(p_time)) {
_quit = true;
}
Expand All @@ -537,8 +530,6 @@ bool SceneTree::process(double p_time) {
MessageQueue::get_singleton()->flush(); //small little hack
flush_transform_notifications(); //transforms after world update, to avoid unnecessary enter/exit notifications

root_lock--;

_flush_delete_queue();

if (unlikely(pending_new_scene)) {
Expand Down
3 changes: 0 additions & 3 deletions scene/main/scene_tree.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,6 @@ class SceneTree : public MainLoop {

Window *root = nullptr;

uint64_t tree_version = 1;
double physics_process_time = 0.0;
double process_time = 0.0;
bool accept_quit = true;
Expand All @@ -134,7 +133,6 @@ class SceneTree : public MainLoop {
bool debug_navigation_hint = false;
#endif
bool paused = false;
int root_lock = 0;

HashMap<StringName, Group> group_map;
bool _quit = false;
Expand Down Expand Up @@ -165,7 +163,6 @@ class SceneTree : public MainLoop {

// Safety for when a node is deleted while a group is being called.

bool processing = false;
int nodes_removed_on_group_call_lock = 0;
HashSet<Node *> nodes_removed_on_group_call; // Skip erased nodes.

Expand Down
Loading