Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display Godot version and last edited timestamp in project manager #90770

Merged
merged 1 commit into from
May 22, 2024

Conversation

kitbdev
Copy link
Contributor

@kitbdev kitbdev commented Apr 16, 2024

Shows the project version and the last edited timestamp for each project.
The version has the same tooltip as the unsupported features icon.

If the project major version is the same and the minor version is before the current version, do not show warning. (godotengine/godot-proposals#9384 (comment))
I couldn't check patches, since they aren't stored.

Adds a warning for projects edited in 3.x (config version 4). They didn't have one before since they don't have supported features.
Also adds a warning for config versions before 4 of "Unknown version".

image

@JekSun97
Copy link
Contributor

This is what has been missing for so long! Thank you!

Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally (rebased on top of master 2149682), it works as expected.

UI looks good to me. We could perhaps colorize version numbers later (use the warning color if different than the current version), but this should suffice for now.

Before After
image image

On projects with a warning (due to requiring conversion or being C# projects in a non-C# build), the warning icon is displayed like this:

image

@akien-mga akien-mga modified the milestones: 4.x, 4.3 May 22, 2024
@akien-mga
Copy link
Member

Looks good overall, let's give it a spin.

I think the timestamp takes a lot of space and in the provided screenshots, tend to overlap/cut into the project path. We might want to look into options to make it less intrusive (e.g. only include the date and not the time, or include the time only for things which are at most a week old, and remove seconds anyway, etc.).

@akien-mga akien-mga changed the title Display godot version and last edited timestamp in project manager Display Godot version and last edited timestamp in project manager May 22, 2024
@akien-mga akien-mga merged commit 381ce56 into godotengine:master May 22, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@kitbdev kitbdev deleted the show-version branch May 22, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display the godot version instead of a warning sign in the project manager
5 participants