Fix port cache calculation in GraphNode #91083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Naros
approved these changes
Apr 23, 2024
Rindbee
reviewed
Apr 23, 2024
Rindbee
approved these changes
Apr 24, 2024
|
@Geometror See also #90229 and #90787. Seems like it's easy to make mistakes in this code with different indices. |
|
@akien-mga Yes indeed (child index, slot index and port index), but unfortunately that's just how the current system works. Changing this would basically require a complete rework of GraphNode/GraphEdit (much more sophisticated than the refactoring I've done). Maybe for 5.0 :) |
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #91082 by updating the
left_port_cache&right_port_cachecalculation inGraphNode::_port_pos_update.