Fix Tree minimum size calculation #91095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As long as there is a tooltip that displays the full title of a node with a title longer than can be displayed, I think 'no horizontal scrollbar' is the preferred fix. Horizontal scrolling is simply always cumbersome IMO. EDIT: clarified what I meant with 'this fix'. |
KoBeWi
reviewed
Apr 24, 2024
| min_size.y += bg->get_margin(SIDE_TOP) + bg->get_margin(SIDE_BOTTOM); | ||
| } | ||
| return Vector2(h_scroll_enabled ? 0 : min_size.x, v_scroll_enabled ? 0 : min_size.y); | ||
| Vector2 min_size = Vector2(0, _get_title_button_height()); |
There was a problem hiding this comment.
Shouldn't this be ignored when vertical scroll is enabled?
There was a problem hiding this comment.
Vertical scrollbar does not scroll the title.
KoBeWi
reviewed
Apr 24, 2024
KoBeWi
approved these changes
Apr 24, 2024
|
Needs rebase to fix CI. |
- Take scroll bar space and column title buttons into account - Fix first column min size sometimes missing one level of indent - Fix cell min size ignoring text overrun behavior and item inner margin - Update min size when `hide_root` or `column_title_visible` changes Wrong description of `item_inner_margin_*` constants is also fixed
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #91047
hide_rootorcolumn_title_visiblechangesAlso fixed wrong description of
item_inner_margin_*constants. They are actually applied to cells instead of items (rows) in the PR that introduced them. The naming is unfortunate, but I don't think it's worth breaking compat for.This PR accidentially fixed the problem that Scene dock uses both text ellipsis and horizontal scrollbar (and the scrollbar did not allow you to see the whole text) 🤣
If the horizontal scrollbar is preferred, all we need to do is setting the text overrun behavior to "no trimming".